feat: add (loadType/deleteValue/pvc) in Cluster New , and add deleteValue in Tenant New #641
+187
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TianWuwt
changed the title
powerfooI
reviewed
Nov 20, 2024
| { | ||
| value: 'KV', | ||
| label: 'KV', | ||
| }, |
There was a problem hiding this comment.
express_oltp_perf was omitted.
| @@ -173,7 +192,21 @@ export default function Observer({ storageClasses, form }: ObserverProps) { | |||
| </Col> | |||
| </Row> | |||
| <p className={styles.titleText}>storage</p> | |||
|
|
|||
| <p className={styles.subTitleText}>存储卷配置</p> | |||
There was a problem hiding this comment.
Why not use CustomFormItem? I don't think this form item for pvc protection is special among other items.
| export default function Observer({ | ||
| storageClasses, | ||
| form, | ||
| pvcValue, |
There was a problem hiding this comment.
Why not put this item into the form?
| </Col> | ||
|
|
||
| <Col span={8}> | ||
| <Form.Item name={['deleteVal']} label={<></>}> |
There was a problem hiding this comment.
Why leave an empty label here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e in Tenant New
Summary
feat(): add loadType 、deleteValue、pvc in Cluster New ,add deleteValue in Tenant New
Solution Description